This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
global ocean init updates for QU_120 ecosys #1035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the input data initial conditions (IC) had to be on the same vertical grid as the final grid produced in init_step2. This PR includes the following: - independant vertical grids for activeTracer IC, ecosystem IC, and final IC. - new test case, QU_240km/zstar_128_layers, makes use of interpolation from 100 layer IC data files to 128 layer MPAS IC file. - substantial clean-up of mpas_ocn_init_global_ocean.F - unification of interpolation and smoothing routine for active tracers and ecosystem tracers (was two routines before) - read in data IC for each tracer separately. Before, T&S were within a loop, so we would read in data T&S IC together and sometimes run out of memory. This PR prepares for sigma and hybrid coordinate initialization, but does not yet implement them. This PR is bit-for-bit against ocean/develop using the nightly regresssion test, except for 'with land ice', which was close. The QU_120km/bgc_60_layer was also tested and works.
|
@maltrud what is the status of this PR? Do you use the code in this PR when you initialize initial conditions? I would like to merge all possible PRs in the next few days to the 'merge branch', and this only changes the init mode and test suite. |
|
@maltrud Could you take a look at this PR? Is it still needed? Since we are making new BGC initial conditions soon, it would be good to look at this again. |
|
@mark-petersen i'm happy to punt this PR. there is nothing crucial there that we can't kick down the road. |
|
OK. The current round of PRs is for the forward model. The next round will be for initialization, including this one. Should be next week, when I make that RRS30to10V3 as well (sorry). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request adds/fixes the ability for the ecosysAuxiliary var_struct (includes surface deposition, pH, etc) to be initialized correctly and dumped to the output file after a forward run.