This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Bug fix in MPAS_stream_mgr_add_att_int that prevents adding integer attributes #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttributes to streams, and typo in debug message
climbfuji
changed the title
|
@mgduda the standard init_atmosphere and atmosphere core don't add attributes to individual streams, i.e. the error doesn't show up. For SIONlib, we do add attributes for the SIONlib streams only, and in this case the bug is serious. I still cannot add labels, milestones etc. in Github. |
|
@mgduda just added a tiny fix to the number of padded zeros when generating the log.***.abort messages; this really tiny and not worth creating a separate branch/PR |
|
@climbfuji Just to keep the pull requests tidy, would you be willing to move the log file changes to a separate PR? |
climbfuji
force-pushed
the
framework/MPAS_stream_mgr_add_att_int-release-5.0
branch
from
0829afd
to
4ee046e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subroutine MPAS_stream_mgr_add_att_int contains a bug when searching for a stream with given streamID. The do-while statement tests for .not. MPAS_stream_list_query(..) where it should test for the opposite (as it is the case for add_att_real and all others). Second fix is a typo in a debug message in mpas_stream_list.F.