Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Optimized OMP with not bit-reproducible updates #1164

Conversation

mywoodstock
Copy link
Member

This PR has the non-bit-reproducible updates. This should be merged first, followed by the previous PR, which also includes bit-reproducible updates.

@mark-petersen
Copy link
Contributor

@mywoodstock not sure if you are listening. What if I split the MPAS framework changes here in the file src/operators/mpas_vector_reconstruction.F into a different pull request? Could I merge the remaining two files in this PR? i.e. the changes in the different files are not dependent on each other, right?

@mywoodstock
Copy link
Member Author

@mark-petersen apologies for delay in reply. The changes in the reconstruction routine only involve adding threading in there, so it is independent of the rest of the ocean code, BUT if this update is merged separately, the location where the mpas_reconstruct routine is called within the ocean core, needs to be back within the "omp single" constructs so that just one thread calls them.
On the other hand, if this change is merged in, it will not affect any other cores as long as they are (1) not using openmp (not compiled with OpenMP support), or (2) if using openmp, the threading of this routine is independent from the rest.

@mark-petersen
Copy link
Contributor

This PR was rebased and separated into #1235, #1236, and #1237

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants