This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Rename get-tend in mpas_atmphys_todynamics #1188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sics_addtend and assigned it its own timer
|
@climbfuji I agree that this PR represents legitimate cleanup; however, I'm a little reluctant to make any non-critical (i.e., not bugfix) changes right now: I'm hoping that we can release v5.0 tomorrow. Anyone looking down into the code for obtaining physics tendencies will no doubt see many areas that need to be cleaned up (for example, we should probably just delete the "addtend" routines altogether, since they are never used). Would you be willing to target the 'develop' branch instead so these changes will appear in the v6.0 release? |
|
@mgduda no problem, done! |
|
I think the changes in this PR are effectively superseded by those in PR #1499 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed physics_get_tend routines to physics_gettend in line with physics_addtend and assigned it its own timer.