This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Cice/njeffery tracer fix2 #1261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BFB in physics. -Contains zbgc bug fixes and updated Registry parameters. -r1163 is a merge of hilat_colpkg r1158:1163 (see 1163 revision log) -One change to MPAS interface: Added openWaterArea to biogeochemistry call. -r1164 corrects an initialization error in a bgc flux calculation.
1. Update to acme_colpkg.r1174: Contains corrections to tracer regridding and aerosol feedback. 2. Small correction to mpas_cice_column.F to be compatible with r1174. 3. Updated Registry parameters for bgc.
|
@akturner : I've tested this for bfb parallel and restartability with and without the bgc flags on. |
|
Has Elizabeth finished refactoring the CICE acme repo?
Ade
…On 3/6/17 2:18 PM, Nicole Jeffery wrote:
@akturner <https://github.com/akturner> : I've tested this for bfb
parallel and restartability with and without the bgc flags on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1261 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEAA0zX8IQi0QiEkXSZhePO6hdkCOK_Dks5rjHgRgaJpZM4MUs-N>.
|
|
Don't know. |
|
I merged Adrian’s changes at CICE svn r1175 backwards into r1143, in order to avoid Nicole’s bgc changes. I have not checked this version into svn because it will need to be put on a separate branch, which requires Phil standing by to shut down the permissions (and I’m home sick today). Since Nicole’s bgc changes are ready, I suggest going ahead and getting those in, then doing the warnings, since this will be less error-prone than using my back-merged code.
Note that the critical difference in congelation code (in ice_therm_vertical.F90) is NOT in the acme_colpkg branch on svn at the moment, it’s only in MPAS’s version (and my working directory).
e
On Mar 6, 2017, at 2:22 PM, akturner <notifications@github.com<mailto:notifications@github.com>> wrote:
Has Elizabeth finished refactoring the CICE acme repo?
Ade
On 3/6/17 2:18 PM, Nicole Jeffery wrote:
@akturner <https://github.com/akturner> : I've tested this for bfb
parallel and restartability with and without the bgc flags on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1261 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEAA0zX8IQi0QiEkXSZhePO6hdkCOK_Dks5rjHgRgaJpZM4MUs-N>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#1261 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHy5nyJajjrw_75usmopHd_01B_NPUG0ks5rjHkygaJpZM4MUs-N>.
TSPA/DUSA PLNT
Correspondence
o
o Elizabeth Hunke
o Deputy Group Leader
o T-3 Fluid Dynamics and Solid Mechanics Group
o MS-B216
o Los Alamos National Laboratory
o Los Alamos, NM 87545
o office 505 665 9852
o fax 505 665 5926
o eclare@lanl.gov<mailto:eclare@lanl.gov>
o http://climate.lanl.gov<http://climate.lanl.gov/>
|
|
On 3/6/17 2:38 PM, Elizabeth Hunke wrote:
I merged Adrian’s changes at CICE svn r1175 backwards into r1143, in
order to avoid Nicole’s bgc changes. I have not checked this version
into svn because it will need to be put on a separate branch, which
requires Phil standing by to shut down the permissions (and I’m home
sick today). Since Nicole’s bgc changes are ready, I suggest going
ahead and getting those in, then doing the warnings, since this will
be less error-prone than using my back-merged code.
Merges into cice/develop need to be orchestrated with pushes into ACME,
so the order cant be decided so easily.
Note that the critical difference in congelation code (in
ice_therm_vertical.F90) is NOT in the acme_colpkg branch on svn at the
moment, it’s only in MPAS’s version (and my working directory).
I dont really know what this means
… e
On Mar 6, 2017, at 2:22 PM, akturner
***@***.******@***.***>> wrote:
Has Elizabeth finished refactoring the CICE acme repo?
Ade
On 3/6/17 2:18 PM, Nicole Jeffery wrote:
>
> @akturner <https://github.com/akturner> : I've tested this for bfb
> parallel and restartability with and without the bgc flags on.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1261 (comment)>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AEAA0zX8IQi0QiEkXSZhePO6hdkCOK_Dks5rjHgRgaJpZM4MUs-N>.
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on
GitHub<#1261 (comment)>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AHy5nyJajjrw_75usmopHd_01B_NPUG0ks5rjHkygaJpZM4MUs-N>.
TSPA/DUSA PLNT
Correspondence
o
o Elizabeth Hunke
o Deputy Group Leader
o T-3 Fluid Dynamics and Solid Mechanics Group
o MS-B216
o Los Alamos National Laboratory
o Los Alamos, NM 87545
o office 505 665 9852
o fax 505 665 5926
o ***@***.******@***.***>
o http://climate.lanl.gov<http://climate.lanl.gov/>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1261 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEAA0_1vrZZGsa9IPGti_6g1Jh5284ioks5rjHzFgaJpZM4MUs-N>.
|
|
This will now need to be updated to include the changes to warning messages brought in by #1266 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes to the ice biogeochemistry (acme_colpkg.r1174). BFB in physics
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
#930
#931