This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Removed if-test around call to update_radiation_diagnostics in mpas_a… #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tmphys_driver.F Previously, the routine update_radiation_diagnostics to update the accumulated radiation variables (acswdnb etc) was only called if config_bucket_update /= 'none' and config_bucket_radt .gt. 0._RKIND. Inside the routine, the current values of the (temporary) fields (swdnb etc) are multiplied by dt_dyn and added to the accumulated (permanent) fields. Only after that, another test of config_bucket_update and config_bucket_radt is done and the overflow values transferred to the buckets, if requested. If config_bucket_update is set to none, the information stored in the temporary fields (swdnb etc) is lost at the end of the time step and the accumulated fields remain zero for the entire integration. This is not the intended method, as users may wish to get the information on accumulated radiation also for shorter runs, for which the buckets may not be needed.
mgduda
force-pushed
the
atmosphere/develop
branch
from
eb49435
to
ef59b34
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the routine update_radiation_diagnostics to update the accumulated
radiation variables (acswdnb etc) was only called if "config_bucket_update /= 'none'"
and "config_bucket_radt .gt. 0._RKIND". Inside the routine, the current values of
the (temporary) fields (swdnb etc) are multiplied by dt_dyn and added to the
accumulated (permanent) fields. Only after that, another test of config_bucket_update
and config_bucket_radt is done and the overflow values transferred to the buckets,
if requested. If config_bucket_update is set to none, the information stored in
the temporary fields (swdnb etc) is lost at the end of the time step and the
accumulated fields remain zero for the entire integration (i.e. the entire information
on accumulated radiation fields is lost). This is not the intended method, as users
may wish to get the information on accumulated radiation also for shorter runs,
for which the buckets may not be needed.
This PR was originally intended as a hotfix of v5.1, but after discussions with @mgduda and @ldfowler58 we decided to include it in atmosphere/develop for the next major release. It wasalso discussed that we should add a short section explaining about the buckets in general (for precip and radiation) to the user's guide.