This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Enable user to specify output path for sounding files #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new namelist option in the &soundings record, config_sounding_output_path, that selects the path where sounding output files will be written. The default value is "./". Before writing any sounding files, the sounding module will attempt to create the specified directory with "mkdir -p" via a system command.
… directory The 'system' subroutine has apparently not been standardized, so we instead use 'execute_command_line' from Fortran 2008.
The call to execute_command_line to create the sounding file output directory
inexplicably segfaults for some model configurations (e.g., the 15-3 km HWT runs)
but not others (e.g., a basic 120-km test run). This appears to be some issue
with the execute_command_line routine itself:
* calling with 'mkdir -p '//trim(soundingPath) segfaults
* calling with
tempcmd = 'mkdir -p '//trim(soundingPath)
call execute_command_line(trim(tempcmd), ...)
also segfaults
* calling with
tempcmd = 'mkdir -p '//trim(soundingPath)
call execute_command_line(tempcmd, ...)
seems to be working
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds a new namelist option in the &soundings record,
config_sounding_output_path, that selects the path where sounding output
files will be written. The default value is "./". Before writing any
sounding files, the sounding module will attempt to create the specified
directory with "mkdir -p" via a call to the Fortran 2008 routine execute_command_line.