Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Ocean/global_stats: Removed land cells from stats, added readme file #5

Closed

Conversation

mark-petersen
Copy link
Contributor

The global_stats branch is now ready for review. Alterations include:

  1. Addition of stats_readme.txt file
  2. remove land cells from computations
  3. remove white space from stats_time.txt

I tested it with the 120km global and 10km overflow. Both match output files bit-for-bit with master.

Min and Avg stats are no longer contaminated by -1e34:
120km, master branch. Columns are temperature, salinity, tracer1

lo1-fe.lanl.gov> cut -c 363-500 stats_max.txt | tail -n 1
2.86914922866561E+01 3.74667462059278E+01 1.00000000000000E+00
lo1-fe.lanl.gov> cut -c 363-500 stats_avg.txt | tail -n 1
-3.08606381137871E+33 -3.08606381137871E+33 -3.08606381137871E+33
lo1-fe.lanl.gov> cut -c 363-500 stats_min.txt | tail -n 1
-1.00000000000000E+34 -1.00000000000000E+34 -1.00000000000000E+34

120km, global_stats branch

lo1-fe.lanl.gov> cut -c 363-500 stats_max.txt | tail -n 1
2.86914922866561E+01 3.74667462059278E+01 1.00000000000000E+00
lo1-fe.lanl.gov> cut -c 363-500 stats_avg.txt | tail -n 1
3.40931804591106E+00 3.47108117173064E+01 1.00000000000000E+00
lo1-fe.lanl.gov> cut -c 363-500 stats_min.txt | tail -n 1
-1.74337564684972E+00 2.45582429725827E+01 9.99999999999998E-01

Mark R. Petersen added 3 commits April 30, 2013 10:52
3.1. add stats_readme.txt file, created on initialization, with variable names written to each column of stats files
3.3. cut white space out of stats_time.txt
That is, only loop down to maxLevelCell etc.
that use maxLevel* to avoid land cells.

This branch is now ready for review.  I tested it with the 120km global
and 10km overflow.  Both match output files bit-for-bit with master.

Min and Avg stats are no longer contaminated by -1e34:
120km, master branch.  Columns are temperature, salinity, tracer1

lo1-fe.lanl.gov> cut -c 363-500 stats_max.txt | tail -n 1
  2.86914922866561E+01    3.74667462059278E+01    1.00000000000000E+00
lo1-fe.lanl.gov> cut -c 363-500 stats_avg.txt | tail -n 1
 -3.08606381137871E+33   -3.08606381137871E+33   -3.08606381137871E+33
lo1-fe.lanl.gov> cut -c 363-500 stats_min.txt | tail -n 1
 -1.00000000000000E+34   -1.00000000000000E+34   -1.00000000000000E+34

120km, global_stats branch

lo1-fe.lanl.gov> cut -c 363-500 stats_max.txt | tail -n 1
  2.86914922866561E+01    3.74667462059278E+01    1.00000000000000E+00
lo1-fe.lanl.gov> cut -c 363-500 stats_avg.txt | tail -n 1
  3.40931804591106E+00    3.47108117173064E+01    1.00000000000000E+00
lo1-fe.lanl.gov> cut -c 363-500 stats_min.txt | tail -n 1
 -1.74337564684972E+00    2.45582429725827E+01    9.99999999999998E-01
@ghost ghost assigned douglasjacobsen Apr 30, 2013
@douglasjacobsen
Copy link
Member

I tested, and the results are bit-for-bit identical to the MPAS-Dev/develop.

With one exception.

The changes to mpas_ocn_mpas_core.F in commit d4c80b4 change the initial output frame. These changes cause tracer values on land cells (in a column with some ocean cells) to have an initial value of -1e34, so differences with develop in the initial frame are of the order 1e33 in tracers.

This also fixes item 4 on our task lists related to the first output frame not containing -1e34 like later frames do.

I used a 240km ocean grid to test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants