Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merry-go-round test case for vertical and horizontal advection #108

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

scalandr
Copy link
Collaborator

@scalandr scalandr commented May 4, 2021

This test case is meant to analyze the accuracy of the tracers' horizontal and vertical advection. The horizontal and vertical velocity profiles are constant in time, therefore RK4 is used as time-stepping scheme. The meshes used are planar with 100, 200 and 400 cells per y-layer. The numbers of vertical layers is 50, 100 and 200 for the 100, 200 and 400 cell meshes, respectively. It is a steady state test case, so the initial condition is the analytical solution which should remain over all time integration. For each mesh, plots of the horizontal velocity, vertical velocity and tracer fields after a 6 hour run time are created. Finally, a convergence plot that shows second-order convergence with increasing grid refinement is created.

@pep8speaks

This comment has been minimized.

@xylar xylar added legacy DEPRECATED: PRs or Issues related to the legacy branch of COMPASS ocean labels May 4, 2021
@xylar xylar requested a review from mark-petersen May 4, 2021 19:50
@scalandr
Copy link
Collaborator Author

scalandr commented May 5, 2021

Here the plots associated to the test case:

horizontal velocity, vertical velocity and tracer field for the 100 cell case:
100Cells
horizontal velocity, vertical velocity and tracer field for the 200 cell case:
200Cells
horizontal velocity, vertical velocity and tracer field for the 400 cell case:
400Cells
convergence plot:
order

@scalandr
Copy link
Collaborator Author

scalandr commented May 5, 2021

I did a commit after fixing PEP8 issues.

@xylar
Copy link
Collaborator

xylar commented Feb 6, 2022

@mark-petersen and @scalandr, could you have a conversation about whether this test case still makes sense in legacy, if you want to port it to the new approach in master, or if you want to close this for now and revisit it later?

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good to me. I tested all three resolutions and the analysis. The python init step is a bit slow for the number of cells - 4 minutes for the 800 cell case - but we don't run it very often, so it's OK. The section.png plots looked exactly like yours. Thanks @scalandr!

@mark-petersen mark-petersen merged commit 7fcaa5f into MPAS-Dev:legacy Feb 15, 2022
@mark-petersen mark-petersen mentioned this pull request Oct 26, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy DEPRECATED: PRs or Issues related to the legacy branch of COMPASS ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants