-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merry-go-round test case for vertical and horizontal advection #108
Conversation
This comment has been minimized.
This comment has been minimized.
I did a commit after fixing PEP8 issues. |
@mark-petersen and @scalandr, could you have a conversation about whether this test case still makes sense in |
442a705
to
8aea93f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks good to me. I tested all three resolutions and the analysis. The python init step is a bit slow for the number of cells - 4 minutes for the 800 cell case - but we don't run it very often, so it's OK. The section.png plots looked exactly like yours. Thanks @scalandr!
This test case is meant to analyze the accuracy of the tracers' horizontal and vertical advection. The horizontal and vertical velocity profiles are constant in time, therefore RK4 is used as time-stepping scheme. The meshes used are planar with 100, 200 and 400 cells per y-layer. The numbers of vertical layers is 50, 100 and 200 for the 100, 200 and 400 cell meshes, respectively. It is a steady state test case, so the initial condition is the analytical solution which should remain over all time integration. For each mesh, plots of the horizontal velocity, vertical velocity and tracer fields after a 6 hour run time are created. Finally, a convergence plot that shows second-order convergence with increasing grid refinement is created.