Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SOMA and ZISO script links #21

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 9, 2020

There are two testcases that use links to testing_and_setup/compass using mpas_model as the base. This was never the intended way of finding contents of testcases, and no longer works now that COMPASS is in its own repo. These two links have been fixed in this merge.

partially addresses #20

@xylar xylar requested a review from mark-petersen November 9, 2020 21:46
@xylar xylar self-assigned this Nov 9, 2020
@xylar
Copy link
Collaborator Author

xylar commented Nov 9, 2020

@mark-petersen, will this be easy for you to test?

@xylar xylar added bug Something isn't working ocean labels Nov 9, 2020
@xylar
Copy link
Collaborator Author

xylar commented Nov 10, 2020

Testing

I didn't actually try to run these tests but the links are now correct:

xylar@burnham:~/data/mpas/test_soma_ziso/ocean/ziso/20km/default/forward$ ls -lah
...
lrwxrwxrwx 1 xylar xylar  105 Nov 10 15:05 make_particles.py -> /home/xylar/code/mpas-work/compass/fix_soma_ziso_links/ocean/scripts/LIGHTparticles/make_particle_file.py

and

xylar@burnham:~/data/mpas/test_soma_ziso/ocean/soma/32km/default/analysis$ ls -lah
...
lrwxrwxrwx 1 xylar xylar  101 Nov 10 15:05 check_particle_sampling.py -> /home/xylar/code/mpas-work/compass/fix_soma_ziso_links/ocean/soma/analysis/check_particle_sampling.py

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nightly test suite, with compiled MPAS-O within the compass subdirectory. Worked great. thanks.

@xylar xylar merged commit 48dd964 into MPAS-Dev:master Nov 12, 2020
@xylar xylar deleted the fix_soma_ziso_links branch November 12, 2020 18:21
@xylar
Copy link
Collaborator Author

xylar commented Nov 12, 2020

Thanks, @mark-petersen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants