-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on surface restoring for all dynamic adjustment #309
Turn on surface restoring for all dynamic adjustment #309
Conversation
@mark-petersen, I have not yet had any time to test this. I will post as soon as I do. |
@mark-petersen and @vanroekel, related to #310, we should revisit whether or not we want surface restoring. @mark-petersen seemed to want it before but then seems to be changing his mind in recent discussions of results using the Redi fix in E3SM-Project/E3SM#4785. I'm fine either way but would like to know whether to close this or retest once E3SM-Project/E3SM#4785 goes in. |
@xylar I gave this some more thought, and I would still like to have surface restoring on, as it keeps spin-up closer to climatology and is more physical for any longer stand-alone simulations. |
For the short dynamic adjustment phase, I have no preference either way. If we are spinning up for only a month or two in stand alone, I can't imagine it having a long term impact in E3SM on or off. So I'm fine with going with it on as desired by @mark-petersen. |
12d1227
to
fbad0c5
Compare
@xylar, I tested this PR with:
but it still shows
in all the |
@mark-petersen, thanks. I'll check this. |
@mark-petersen, I don't think we run any |
I'm seeing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that was just my misunderstanding about which case we turn it on for. Thanks, this looks good.
Tested along with #310. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving based on visual inspection and testing by @xylar and @mark-petersen
fbad0c5
to
e0155ea
Compare
This merge re-enables surface restoring of tracers in the dynamic adjustment test cases from the global ocean test group. This choice was discussed at length in #308.
This merge also enables GM in the QU240 configuration to be (somewhat) more consistent with other resolutions. QU240 also enables many features that are not used at other resolutions.