Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on surface restoring for all dynamic adjustment #309

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 31, 2022

This merge re-enables surface restoring of tracers in the dynamic adjustment test cases from the global ocean test group. This choice was discussed at length in #308.

This merge also enables GM in the QU240 configuration to be (somewhat) more consistent with other resolutions. QU240 also enables many features that are not used at other resolutions.

@xylar xylar added ocean python package DEPRECATED: PRs and Issues involving the python package (master branch) labels Jan 31, 2022
@xylar xylar requested a review from mark-petersen January 31, 2022 18:42
@xylar xylar self-assigned this Jan 31, 2022
@xylar
Copy link
Collaborator Author

xylar commented Jan 31, 2022

@mark-petersen, I have not yet had any time to test this. I will post as soon as I do.

@xylar
Copy link
Collaborator Author

xylar commented Feb 11, 2022

@mark-petersen and @vanroekel, related to #310, we should revisit whether or not we want surface restoring. @mark-petersen seemed to want it before but then seems to be changing his mind in recent discussions of results using the Redi fix in E3SM-Project/E3SM#4785.

I'm fine either way but would like to know whether to close this or retest once E3SM-Project/E3SM#4785 goes in.

@mark-petersen
Copy link
Collaborator

@xylar I gave this some more thought, and I would still like to have surface restoring on, as it keeps spin-up closer to climatology and is more physical for any longer stand-alone simulations.

@vanroekel
Copy link
Collaborator

For the short dynamic adjustment phase, I have no preference either way. If we are spinning up for only a month or two in stand alone, I can't imagine it having a long term impact in E3SM on or off. So I'm fine with going with it on as desired by @mark-petersen.

@xylar xylar force-pushed the reenable_global_ocean_surface_restoring branch from 12d1227 to fbad0c5 Compare March 20, 2022 14:09
@mark-petersen
Copy link
Collaborator

@xylar, I tested this PR with:

./conda/configure_compass_env.py --conda /usr/projects/climate/mpeterse/miconda3 --compiler gnu
source load_dev_compass_1.0.0_grizzly_gnu_mvapich.sh
compass suite -s -c ocean -t nightly -f Config_dir/master -w $WORKDIR

but it still shows

    config_use_activeTracers_surface_restoring = .false.

in all the global_ocean cases. I might have made a mistake, but this is the normal process I use. @xylar can you double-check that your test changes this flag?

@xylar
Copy link
Collaborator Author

xylar commented Mar 20, 2022

@mark-petersen, thanks. I'll check this.

@xylar
Copy link
Collaborator Author

xylar commented Mar 20, 2022

@mark-petersen, I don't think we run any dynamic_adjustment tests in either nightly or pr test suites. I didn't turn on surface restoring for performance tests etc. It's not clear to me why that would be important to do.

@xylar
Copy link
Collaborator Author

xylar commented Mar 20, 2022

I'm seeing config_use_activeTracers_surface_restoring = .true. as expected within the steps in dynamic_adjustment where I looked.

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that was just my misunderstanding about which case we turn it on for. Thanks, this looks good.

@xylar
Copy link
Collaborator Author

xylar commented Mar 22, 2022

Tested along with #310.

Copy link
Collaborator

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving based on visual inspection and testing by @xylar and @mark-petersen

@xylar xylar force-pushed the reenable_global_ocean_surface_restoring branch from fbad0c5 to e0155ea Compare March 23, 2022 12:07
@xylar xylar merged commit 6b2ecc3 into MPAS-Dev:master Mar 23, 2022
@xylar xylar deleted the reenable_global_ocean_surface_restoring branch March 23, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E3SM PR finished ocean python package DEPRECATED: PRs and Issues involving the python package (master branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants