Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of max temp. during dynamic adjustment #328

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 21, 2022

This will hopefully catch issues like #308

@xylar
Copy link
Collaborator Author

xylar commented Mar 21, 2022

Testing

I'm testing dynamic adjustment on Anvil and Intel with this test.

  • EC30to60: this fails as expected
ValueError: Max of temperatureMax > allowed threshold: 54.22333235731241 > 33.0 in 
/lcrc/group/e3sm/ac.xylar/compass_1.0/anvil/test_20220321/dyn_adj_ec_validate_temp_redi_min_6/
ocean/global_ocean/EC30to60/PHC/dynamic_adjustment/damped_adjustment_2/analysis_members/
globalStats.0001-01-11_00.00.00.nc
  • ECwISC30to60: this fails as (more or less) expected
ValueError: Max of temperatureMax > allowed threshold: 35.95204635559652 > 33.0 in 
/lcrc/group/e3sm/ac.xylar/compass_1.0/anvil/test_20220321/dyn_adj_ecwisc_validate_temp_redi_min_6/
ocean/global_ocean/ECwISC30to60/PHC/dynamic_adjustment/damped_adjustment_2/analysis_members/
globalStats.0001-01-11_00.00.00.nc

@xylar xylar added ocean python package DEPRECATED: PRs and Issues involving the python package (master branch) enhancement New feature or request labels Mar 21, 2022
@xylar xylar self-assigned this Mar 21, 2022
@xylar xylar requested a review from mark-petersen March 21, 2022 18:47
Comment on lines +77 to +78
# the maximum allowed value of temperatureMax in global statistics
temperature_max = 33.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to make sure this threshold is reasonable.

@xylar
Copy link
Collaborator Author

xylar commented Mar 21, 2022

@mark-petersen, this is ready for your review. Is 33.0 C a good threshold in you opinion?

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar this is a great idea! Thanks for implementing it. Yes, I think 33C is an appropriate value. We can be conservative here, as it will tell us if the max is increasing at all.

Approving based on this catching increasing temperatures in the tests above.

@xylar xylar merged commit fff55ef into MPAS-Dev:master Mar 22, 2022
@xylar xylar deleted the validate_max_temp branch March 22, 2022 12:39
@xylar
Copy link
Collaborator Author

xylar commented Mar 22, 2022

Thanks again @mark-petersen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean python package DEPRECATED: PRs and Issues involving the python package (master branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants