-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation of max temp. during dynamic adjustment #328
Conversation
TestingI'm testing dynamic adjustment on Anvil and Intel with this test.
|
# the maximum allowed value of temperatureMax in global statistics | ||
temperature_max = 33.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to make sure this threshold is reasonable.
@mark-petersen, this is ready for your review. Is 33.0 C a good threshold in you opinion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar this is a great idea! Thanks for implementing it. Yes, I think 33C is an appropriate value. We can be conservative here, as it will tell us if the max is increasing at all.
Approving based on this catching increasing temperatures in the tests above.
Thanks again @mark-petersen! |
This will hopefully catch issues like #308