-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MALI-Dev submodule #333
Update MALI-Dev submodule #333
Conversation
Test execution failed for three tests:
I don't have any ideas for why those failed, but I can try to look into it tomorrow. |
@trhille, are any of those failures new? Or did that happen also with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the sia_integration
suite on Anvil with intel and impi. It ran successfully, using the current submodule as a baseline.
I also looked at the commits in the new submodule compare with the old and they do, indeed, bring in the one PR we are expecting to add.
I'm picking up this PR to re-establish our COMPASS MALI baselines before testing & merging a backlog of PRs we have for MALI. Our MALI COMPASS baselines have been sort of out of date because we had been using a very old version of Albany for testing. With Xylar's recent COMPASS merge #353 now allowing us to more easily keep Albany up to date, we can finally re-establish our baselines. The feature this PR is bringing in to MALI is not on in any test cases, so I'm using this PR as way to identify changes due to the Albany update. I ran our integration suite with our old Badger Albany (
All failures are baseline comparison failures, except one. I confirmed all the changes are small for most tests (e.g. order 1e-12) and could be expected from the changes in Albany since early 2021 (including the b.c. refactoring that Mauro implemented). Changes were not small for the
This is the validation failure:
These three tests require further investigation to resolve. They likely will require adjustments to Albany b.c. settings or initial conditions. I will investigate further and report solutions or issues in additional comments. |
Updated to: a9cc37502113d45b97457fdc2232b80ccedfcda1
The greenland albany_input.yaml file was out of date and resulting in garbage results. Albany had changed units on flowA. But we also had added a realistic temperature field to the input file, so I've removed the Problem section entirely so we use temp-dependent flow rate calculation. I added betaSolve to the output for convenience.
93313b7
to
725cf82
Compare
Albany changed units of flowA. Also, Albany now supports using the flowA value provided by MPAS. So I have removed the flowA specification from the albany_input.yaml file and updated the value in the namelist to be consistent with what we had been using before.
Another adjustment required after updating Albany and after switching to a real temperature field.
725cf82
to
a9b965b
Compare
I rebased this branch so it is on top of the recent Spack merge into master to allow easier testing. I also pushed fixes for the greenland and circular_shelf tests that were failing. Both had to do with changes in Albany and a need to update the Albany yaml file (details in the new commit messages). I reran the |
Update the MALI-Dev submodule. This brings in the merge of MALI-Dev/E3SM#18. This also adds updates for COMPASS tests to work with the current version of Albany supported by COMPASS.