-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kangerlussuaq test group and mesh generation test case #385
Add Kangerlussuaq test group and mesh generation test case #385
Conversation
Add a Kangerlussuaq regional mesh creation test case. This currently fails because of some detail of the geojson file.
Add Kangerlussuaq test group to compass/landice/__init__.py so that it is listed by `compass list`
MpasCellCuller requires a specific format for the geojson file. Because this geojson file came from https://datadryad.org/stash/dataset/doi:10.7280/D1WT11 and not from the geometric_features repository, this had to be manually edited into the correct format.
Use a slightly larger region defined in the geojson file to avoid the glacier reaching the edge of the mesh. This may still need to be extended further. However, testing does not indicate a large difference with the previous version, and this adds >1000 cells in the 1 to 10km mesh with possibly a minimal gain, so perhaps reverting to the previous version will be desireable.
Add documentation for kangerlussuaq test group to users and developers guides. Also update comments in compass/landice/tests/kangerlussuaq/mesh.py, and clean up a few details in humboldt test group documentation.
Update caption for image in kangerlussuaq users guide documentation
The mesh generation only takes about 30 seconds, compared with ~3.5 minutes for Humboldt (I don't understand why; Humboldt is only ~30% larger). The default 1–10km Kangerlussuaq mesh contains 8715 cells. The resulting mesh gives high resolution where desired and preserves the fjord geometry. An older version of the Kangerlussuaq.geojson file in |
Fix PEP8 issues in kangerlussuaq test group
@trhille , this looks good. I didn't notice any issues requiring tweaking in looking over the code, and I was able to easily run this on Badger in 35 seconds. I'm going to note for posterity two issues we discussed earlier today:
|
@trhille and @matthewhoffman, I think you've got the hang of compass and I don't need to review this. But if there's anything specific you want my feedback on, let me know. |
Add a test group and mesh generation test case for Kangerlussuaq, Greenland. This uses mostly the same workflow, datasets, and config options as the Humboldt mesh generation test case.