Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kangerlussuaq test group and mesh generation test case #385

Merged
merged 7 commits into from
May 11, 2022

Conversation

trhille
Copy link
Collaborator

@trhille trhille commented May 5, 2022

Add a test group and mesh generation test case for Kangerlussuaq, Greenland. This uses mostly the same workflow, datasets, and config options as the Humboldt mesh generation test case.

trhille added 6 commits May 4, 2022 14:59
Add a Kangerlussuaq regional mesh creation test case. This currently fails
because of some detail of the geojson file.
Add Kangerlussuaq test group to compass/landice/__init__.py so that it
is listed by `compass list`
MpasCellCuller requires a specific format for the geojson file. Because
this geojson file came from https://datadryad.org/stash/dataset/doi:10.7280/D1WT11
and not from the geometric_features repository, this had to be manually edited
into the correct format.
Use a slightly larger region defined in the geojson file to avoid
the glacier reaching the edge of the mesh. This may still need to be
extended further. However, testing does not indicate a large difference
with the previous version, and this adds >1000 cells in the 1 to 10km mesh
with possibly a minimal gain, so perhaps reverting to the previous version
will be desireable.
Add documentation for kangerlussuaq test group to users and developers guides.
Also update comments in compass/landice/tests/kangerlussuaq/mesh.py, and
clean up a few details in humboldt test group documentation.
Update caption for image in kangerlussuaq users guide documentation
@pep8speaks
Copy link

pep8speaks commented May 5, 2022

Hello @trhille! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-05 15:43:12 UTC

@trhille trhille requested review from xylar and matthewhoffman May 5, 2022 15:36
@trhille
Copy link
Collaborator Author

trhille commented May 5, 2022

The mesh generation only takes about 30 seconds, compared with ~3.5 minutes for Humboldt (I don't understand why; Humboldt is only ~30% larger). The default 1–10km Kangerlussuaq mesh contains 8715 cells. The resulting mesh gives high resolution where desired and preserves the fjord geometry. An older version of the Kangerlussuaq.geojson file in
image
Note: An older version of the Kangerlussuaq.geojson file in b1f7a64 creates a smaller mesh, but risks degrading quality at the fjord walls.

Fix PEP8 issues in kangerlussuaq test group
@trhille
Copy link
Collaborator Author

trhille commented May 5, 2022

The 250m–10km mesh (93k cells) only took 5 minutes to run, and looks good:
image

@matthewhoffman
Copy link
Member

@trhille , this looks good. I didn't notice any issues requiring tweaking in looking over the code, and I was able to easily run this on Badger in 35 seconds.

I'm going to note for posterity two issues we discussed earlier today:

  1. We eventually may be able to generalize all of these mesh gen cases into a single test case that just takes some filenames and x,y coordinates as cfg options to create any mesh in the same workflow. We decided we don't want to hold up this round of mesh generation setups for that but we will tackle that the next time we need to put one together.
  2. We noted that the default thickness interpolation transitions from zero thickness to correct thickness at the terminus over about 3 cells. However, currently we are using a separate interpolation processing workflow that deals with this much better using masks. That will eventually be brought into COMPASS once we generalize the process more, but until then this (and other) mesh creation is really for reproducibly creating the mesh itself, not the entire initial condition.
    image

@xylar
Copy link
Collaborator

xylar commented May 11, 2022

@trhille and @matthewhoffman, I think you've got the hang of compass and I don't need to review this. But if there's anything specific you want my feedback on, let me know.

@xylar xylar removed their request for review May 11, 2022 01:12
@trhille trhille merged commit 2dc80a0 into MPAS-Dev:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants