Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many fixes to the documentation #389

Merged
merged 1 commit into from
May 13, 2022
Merged

Many fixes to the documentation #389

merged 1 commit into from
May 13, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 13, 2022

Some API fixes, some title fixes, some formatting of code blocks.

@xylar
Many fixes to the documentation
af4205c 
Some API fixes, some title fixes, some formatting of code blocks.
@xylar xylar added bug Something isn't working dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels May 13, 2022
@xylar xylar requested a review from trhille May 13, 2022 20:47
@xylar xylar self-assigned this May 13, 2022
@xylar
Copy link
Collaborator Author

xylar commented May 13, 2022

@trhille, in building the docs for #348, I noticed these small issues. Just flagging you to make sure the fixes are correct. Make sure to build the docs as part if your testing. (I forget to test this sometime, too.)

@xylar xylar removed the request for review from trhille May 13, 2022 21:44
@xylar
Copy link
Collaborator Author

xylar commented May 13, 2022

I'm going to go ahead and merge. With these fixes, the docs built locally without any errors.

@xylar xylar merged commit c8f1b60 into MPAS-Dev:master May 13, 2022
@xylar xylar deleted the fix_docstrings_and_docs branch May 13, 2022 21:45
@trhille
Copy link
Collaborator

trhille commented May 16, 2022

@xylar, thanks for catching this, and apologies for the oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @trhille