Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all occurrences of "max_disk" #405

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Remove all occurrences of "max_disk" #405

merged 1 commit into from
Jun 3, 2022

Conversation

altheaden
Copy link
Collaborator

Values were intended for task parallelism but are no longer relevant.

@altheaden
Remove all occurences of "max_disk"
95b1197 
Values were intended for task parallelism but are no longer relevant.
@altheaden altheaden requested a review from xylar June 2, 2022 22:58
@xylar xylar added the ocean label Jun 2, 2022
@xylar
Copy link
Collaborator

xylar commented Jun 3, 2022 •
edited
Loading

Testing

I ran the nightly test suite with these changes and everything ran fine. I didn't test against a baseline, since these changes are not very likely to affect the results. If anything had gone wrong, it would have showed up in the form of failing test execution.

@xylar
Copy link
Collaborator

xylar commented Jun 3, 2022

Thanks @altheaden! Always nice to clean up things we don't need.

@xylar xylar merged commit 479781a into MPAS-Dev:master Jun 3, 2022
@xylar xylar deleted the remove_max_disk branch June 3, 2022 00:18
@xylar xylar mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar Awaiting requested review from xylar

Assignees

@xylar xylar

Labels
clean-up framework ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altheaden @xylar