Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic choice of compiler and MPI for OSX #409

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jun 10, 2022

Previously, there was confusion between just "clang" and "gfortran-clang" as the compiler choice. Now, we just stick with "clang" everywhere (with the understanding that gfortran is still used as the Fortran compiler).

closes #399

@xylar xylar added bug Something isn't working dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Jun 10, 2022
@xylar xylar requested a review from altheaden June 10, 2022 04:53
@xylar xylar self-assigned this Jun 10, 2022
@xylar
Copy link
Collaborator Author

xylar commented Jun 10, 2022

@altheaden, I don't have a mac. Could you check that this fixes #399?

You would just run:

./conda/configure_compass_env.py --conda ~/miniconda3 --env_name compass_test

without specifying the compiler or MPI library. If that works, we're all set! No need to run any further tests.

@altheaden
Copy link
Collaborator

altheaden commented Jun 10, 2022

@xylar, I ran the script as you suggested and this was the output:

Logging to: conda/logs/prebootstrap.log

Doing initial setup

Traceback (most recent call last):
  File "/Users/althea/compass/fix_osx_without_compiler/./conda/configure_compass_env.py", line 118, in <module>
    main()
  File "/Users/althea/compass/fix_osx_without_compiler/./conda/configure_compass_env.py", line 100, in main
    install_miniconda(conda_base, activate_base, logger)
  File "/Users/althea/compass/fix_osx_without_compiler/conda/shared.py", line 177, in install_miniconda
    check_call(commands, logger=logger)
  File "/Users/althea/compass/fix_osx_without_compiler/conda/shared.py", line 144, in check_call
    raise subprocess.CalledProcessError(process.returncode, commands)
subprocess.CalledProcessError: Command 'source /Users/althea/miniconda3/etc/profile.d/conda.sh; conda activate; conda config --add channels conda-forge; conda config --set channel_priority strict; conda install -y "mamba>=0.24.0" boa; conda update -y --all' returned non-zero exit status 1.

Let me know if there's something I can change to test again, or if you want to see the log file.

@xylar
Copy link
Collaborator Author

xylar commented Jun 11, 2022

@altheaden, can you share the contents of conda/logs/prebootstrap.log? From the stack trace you shared, all I can tell is that there's going to be an error message in that log file.

@xylar
Copy link
Collaborator Author

xylar commented Jun 11, 2022

@altheaden, and thanks for testing!

@altheaden
Copy link
Collaborator

@xylar, sorry for the delay, I somehow just noticed this! Here is the log file output you asked for:

running:
   source /Users/althea/miniconda3/etc/profile.d/conda.sh
   conda activate
   conda config --add channels conda-forge
   conda config --set channel_priority strict
   conda install -y "mamba>=0.24.0" boa
   conda update -y --all

Collecting package metadata (current_repodata.json): ...working... failed
Collecting package metadata (current_repodata.json): ...working... failed

Warning: 'conda-forge' already in 'channels' list, moving to the top

ProxyError: Conda cannot proceed due to an error in your proxy configuration.
Check for typos and other configuration errors in any '.netrc' file in your home directory,
any environment variables ending in '_PROXY', and any other system-wide proxy
configuration settings.



ProxyError: Conda cannot proceed due to an error in your proxy configuration.
Check for typos and other configuration errors in any '.netrc' file in your home directory,
any environment variables ending in '_PROXY', and any other system-wide proxy
configuration settings.

So, looks like proxies again... I can try to fiddle with things on my end if you'd like and see if I can get it working?

@xylar
Copy link
Collaborator Author

xylar commented Jun 14, 2022

@altheaden, thanks for checking! I don't think this is something compass can solve or should be expected to, so I do think you'll need to fiddle around with proxy settings and see if you can get past this. Presumably, this error has nothing to do with this branch and would also show up if you try to run with --compiler clang --mpi mpich on the master branch, right?

Previously, there was confusion between just "clang" and
"gfortran-clang" as the compiler choice.  Now, we just stick with
"clang" everywhere (with the understanding that gfortran is still
used as the Fortran compiler)
@xylar xylar force-pushed the fix_osx_without_compiler branch from 6b1c3c7 to 6ff16ca Compare June 15, 2022 07:05
@xylar
Copy link
Collaborator Author

xylar commented Jun 15, 2022

@altheaden, now that I'm back in Germany, I have a Mac I can test on, too. With one more bug fix, this seems to be working for me now. I'm going to go ahead and merge but please re-open #399 if you still have this issue with the new master after I merge. If the proxy issue persists, we'll have to work on that together (or you'll be on your own since I'm not good at these).

@xylar xylar removed the request for review from altheaden June 15, 2022 07:10
@xylar xylar merged commit 0e05bb9 into MPAS-Dev:master Jun 15, 2022
@xylar xylar deleted the fix_osx_without_compiler branch June 15, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when configuring new env on mac without specifying compiler
2 participants