Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ISOMIP+ docs #505

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Fix ISOMIP+ docs #505

merged 3 commits into from
Jan 17, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 14, 2023 •
edited
Loading

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar requested a review from cbegeman January 14, 2023 17:11
@xylar xylar self-assigned this Jan 14, 2023
@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Jan 14, 2023
@xylar
Copy link
Collaborator Author

xylar commented Jan 14, 2023

Testing

I built the documentation locally and complaints about anm incorrect function name in the API documentation went away.

@xylar xylar added documentation Improvements or additions to documentation and removed dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Jan 14, 2023
cbegeman
cbegeman approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Thanks for doing this fixup and for catching the out of date description of the thin film mask step! Let me know if you'd like me to try building the docs on this branch.

xylar and others added 2 commits January 16, 2023 19:46
@xylar
Update docstring
8a94edf
@xylar @cbegeman
Update docs for define_thin_film_mask_step1()
f08a46e 
Co-authored-by: Carolyn Begeman <cbegeman@lanl.gov>
@xylar xylar merged commit f126b1a into MPAS-Dev:main Jan 17, 2023
@xylar xylar deleted the fix_docs branch January 17, 2023 11:58
@xylar
Copy link
Collaborator Author

xylar commented Jan 17, 2023

@cbegeman, thanks very much for your review and for the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbegeman cbegeman cbegeman approved these changes

Assignees

@xylar xylar

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @cbegeman