-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isunnguata sermia mesh generation test case #602
Add isunnguata sermia mesh generation test case #602
Conversation
1bddfd9
to
728cc4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty standard, so I don't have any concerns with the implementation.
Two observations:
- Official name of this glacier has two n's and one s: Isunnguata Sermia (https://tc.copernicus.org/articles/9/2215/2015/tc-9-2215-2015.pdf)
- The cell spacing near the terminus looks strange and not similar to the velocity field. Do you know why that is?
I'm happy to entertain your opinion about to what extent either of these items should be corrected.
Thanks @matthewhoffman. I'm happy to change the name of the test case. Good catch on the velocity-cell spacing mismatch. I believe this stems from the 8km dataset that is used to set cell spacing, while the 1km dataset is used to populate the velocity field after the mesh has been created and culled. I notice that this also leads to an issue with ice thickness abutting the mesh boundary, so I'll fix that. |
5a7390c
to
fd1d453
Compare
That would probably be in MPAS-Tools in the cell culler? If you want to follow up, that would be appreciated. But I also don't think we use the cell quality for anything... |
@trhille , this looks ready to merge with exception of correcting the glacier spelling (which is a lot of changes in file names, variables, docs, etc.). Do you want to do that or leave it as is? My preference would be to fix it, and I'm happy to help do that. |
@matthewhoffman, thanks for the reminder. I'll fix that. |
Add issunguata sermia test group with mesh generation test case.
Use 2km instead of 8km data set to calculate cell width. The 8km data set cause poor cell spacing near the terminus, and an overlap of the ice thickness with the mesh boundary.
Fix spelling error by changing name from Issunguata Sermia to Isunnguata Sermia.
Use updated greenland files from LCRC server that have positive basal heat flux.
198d794
to
d6e62ff
Compare
Rename png file for Isunnguata Sermia to use correct spelling. Also fix short underlines in docs.
3633159
to
a261133
Compare
@matthewhoffman, I went through and fixed that spelling error, and also updated the gridded data set being used to avoid the negative basal heat flux error. This is ready for you whenever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @trhille ! I confirmed I can reproduce the same result.
Add a new
issunguata_sermia
test case with amesh_gen
test group.Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
in this PR) any testing that was used to verify the changes