Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for extrapolating WOA 2023 data #604

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 14, 2023

This merge adds a new utility test group mostly for provenance and ease of updating data sets in the future.

For now, the only test case is ExtrapWoa, used to extrapolate WOA 2023 data into ice-shelf cavities and ice shelves, then into grounded ice, land and below bathymetry.

To convert from in situ to potential temperature, the gsw package has been added as a compass dependency.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean labels Apr 14, 2023
@xylar xylar self-assigned this Apr 14, 2023
@xylar xylar changed the title Add woa23 extrap Add a test group for extrapolating WOA 2023 data Apr 14, 2023
@xylar
Copy link
Collaborator Author

xylar commented Apr 14, 2023

Testing

I ran the test case here:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230414/extrap_woa23_pt/ocean/utility/extrap_woa

The resulting dataset is here:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230414/extrap_woa23_pt/ocean/utility/extrap_woa/extrap/woa23_decav_0.25_extrap.nc

I am also putting it in the initial-condition database for now, so it can be found here:

/lcrc/group/e3sm/public_html/mpas_standalonedata/mpas-ocean/initial_condition_database/woa23_decav_0.25_extrap.20230414.nc

or here:
https://web.lcrc.anl.gov/public/e3sm/mpas_standalonedata/mpas-ocean/initial_condition_database/woa23_decav_0.25_extrap.20230414.nc

@xylar
Copy link
Collaborator Author

xylar commented Apr 14, 2023

@milenaveneziani, @maltrud, @proteanplanet, @vanroekel do any of you have the time and interest in looking at the extrapolated WOA 2023 initial condition that I have created?

I think it's in good shape in terms of how it treats ice-shelf cavities. I think the extrapolation approach is reasonable for grounded ice, land and below bathymetry but I'm open to suggestion there. See:
https://github.com/xylar/compass/blob/add-woa23-extrap/docs/developers_guide/ocean/test_groups/utility.rst#extrap_step
for a description of what I'm doing.

The WOA 2023 data itself certainly has its idiosyncrasies (visible discontinuities and noise in both T and S) that you will no doubt see. In my experience, other datasets are not typically better. If you would like to work with the data from WOA, it is also in the database:

/lcrc/group/e3sm/public/e3sm/mpas_standalonedata/mpas-ocean/initial_condition_database/woa23_decav91C0_*

xylar added 2 commits April 16, 2023 16:54
The ExtrapWoa test case is used to extrapolate WOA 2023 data
first into ice-shelf cavities, then into land and below bathymetry
@xylar xylar force-pushed the add-woa23-extrap branch from 6bc1d11 to 2611ee1 Compare April 16, 2023 14:55
@xylar
Copy link
Collaborator Author

xylar commented Apr 16, 2023

I need to rerun since I found I used the wrong sign for z (positive down depth rather than positive up altitude) when computing the pressure used to convert from in situ temperature to potential temperature.

@xylar xylar force-pushed the add-woa23-extrap branch from 2611ee1 to c4076c2 Compare April 16, 2023 15:18
@xylar
Copy link
Collaborator Author

xylar commented Apr 16, 2023

@milenaveneziani, @maltrud, @proteanplanet and @vanroekel, there is a new version of the extrapolate initial condition here:

/lcrc/group/e3sm/public_html/mpas_standalonedata/mpas-ocean/initial_condition_database/woa23_decav_0.25_extrap.20230414.nc

It has be bug fix mentioned above.

@xylar xylar force-pushed the add-woa23-extrap branch from c4076c2 to 6a23714 Compare April 16, 2023 15:26
@xylar xylar mentioned this pull request Apr 20, 2023
5 tasks
@xylar xylar changed the title Add a test group for extrapolating WOA 2023 data Add a test case for extrapolating WOA 2023 data Apr 21, 2023
@xylar xylar merged commit 822ffb8 into MPAS-Dev:main Apr 21, 2023
@xylar xylar deleted the add-woa23-extrap branch April 21, 2023 19:40
@xylar
Copy link
Collaborator Author

xylar commented Apr 21, 2023

I merged this because it seems like the basic approach is working. I'm find with revisiting either the input dataset or the algorithm later on but this will do as at least a first draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant