-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test case for extrapolating WOA 2023 data #604
Conversation
TestingI ran the test case here:
The resulting dataset is here:
I am also putting it in the initial-condition database for now, so it can be found here:
|
@milenaveneziani, @maltrud, @proteanplanet, @vanroekel do any of you have the time and interest in looking at the extrapolated WOA 2023 initial condition that I have created? I think it's in good shape in terms of how it treats ice-shelf cavities. I think the extrapolation approach is reasonable for grounded ice, land and below bathymetry but I'm open to suggestion there. See: The WOA 2023 data itself certainly has its idiosyncrasies (visible discontinuities and noise in both T and S) that you will no doubt see. In my experience, other datasets are not typically better. If you would like to work with the data from WOA, it is also in the database:
|
The ExtrapWoa test case is used to extrapolate WOA 2023 data first into ice-shelf cavities, then into land and below bathymetry
I need to rerun since I found I used the wrong sign for |
@milenaveneziani, @maltrud, @proteanplanet and @vanroekel, there is a new version of the extrapolate initial condition here:
It has be bug fix mentioned above. |
I merged this because it seems like the basic approach is working. I'm find with revisiting either the input dataset or the algorithm later on but this will do as at least a first draft. |
This merge adds a new
utility
test group mostly for provenance and ease of updating data sets in the future.For now, the only test case is
ExtrapWoa
, used to extrapolate WOA 2023 data into ice-shelf cavities and ice shelves, then into grounded ice, land and below bathymetry.To convert from in situ to potential temperature, the
gsw
package has been added as a compass dependency.Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
in this PR) any testing that was used to verify the changes