-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch global ocean mesh culling and files for E3SM to use python masks #62
Conversation
23ba7e9
to
b9e314d
Compare
@mark-petersen and @vanroekel, I know I've been bombarding you with I will post results from my testing, too, as soon as I have finished. |
Womp-womp-womp... It turns out this branch won't work on Anvil until I get #64 taken care of. That's a big project, too, so I'm closing this for now. |
TestingI will test Tests (checkmark means completed successfully):
TimingHere is a note of the times for different test cases on Chrysalis with intel and impi, for comparison with #85 (comment):
|
This should be more accurate and much more efficient than the C++ serial mask creator because it runs in parallel.
@mark-petersen and @vanroekel, I was going to have you both review this PR but you are both busy with other stuff this week. I would invite you to browse the previous results here (from #85): If you don't have time or interest in looking at these, I think it is reasonable to revisit this as part of creating the next generation of meshes from |
@xylar not sure if it is most appropriate to comment here, but just wanted to say that I'm happy to take a look at the meshes (may not happen until later next week though), but think it will also be good to also revisit this when new meshes come around. It would also be great to get Andrew R's scripts available as a part of the standard workflow analyzing these meshes. |
@vanroekel, fine to comment here. Andrew's scripts are in Matlab as I understand it. The port would be a nontrivial amount of work but I agree with you. |
This merge switches the
global_ocean
test group to using a set of threaded python tools for creating masks. These same tools are being used in MPAS-Analyisis and have been shown to perform better on larger meshes than the C++ equivalents.The python version of the transect mask creator also has the advantage that it follows the transect through polygons on the sphere rather than zig-zagging (which has been a problem with
MpasMaskCreator.x
).The results with the new tools are not expected to be bit-for-bit as compared with the previous mask creator. So the test suites should pass but not bit-for-bit for global ocean test cases.
See MPAS-Dev/MPAS-Tools#399