Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get global ocean resources and time steps based on mesh size #631

Merged
merged 6 commits into from
May 14, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 10, 2023

This merge switches many global ocean steps to getting the core count from either an estimate or exact number of cells in the mesh. Similarly, it switches to computing the time steps (both barotropic and baroclinic) from the minimum resolution of the mesh.

This work paves the way for generalized QU and icosahedral global ocean meshes.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar self-assigned this May 10, 2023
@xylar xylar added enhancement New feature or request ocean labels May 10, 2023
@xylar
Copy link
Collaborator Author

xylar commented May 10, 2023

I'm still seeing hanging in my tests of this branch, similar to #629. In this case, it's for ocean/global_ocean/QU240/WOA23/performance_test/forward.

@xylar xylar force-pushed the add-algorithm-for-global-ocean-cores-dt branch from ce6e5d8 to 4344de0 Compare May 10, 2023 21:21
@xylar
Copy link
Collaborator Author

xylar commented May 10, 2023

Testing

I ran the pr suite on Perlmutter, using the current main as a baseline. Many RK4 tests (perf, decomp, threads) fail the BFB comparison, as expected because the time step has changed (from 5 to 6 minutes). Similarly, EC(wISC)30to60 perf. tests are non-BFB because the time step changed from 5 to 15 minutes and btr_dt changed from 10 to 45 seconds.

All other tests are passing.

@xylar xylar force-pushed the add-algorithm-for-global-ocean-cores-dt branch from d07ced3 to 3bbfd93 Compare May 10, 2023 22:59
@xylar xylar mentioned this pull request May 11, 2023
5 tasks
@xylar xylar force-pushed the add-algorithm-for-global-ocean-cores-dt branch 2 times, most recently from 211b093 to 3626993 Compare May 13, 2023 22:11
xylar added 6 commits May 13, 2023 22:10
This is used to compute the number of MPI tasks based on the
number of grid cells
We want to get the core count from either the estimated or exact
core count and the time step from the minimum resolution.
This is because it may not work with the prescribed time intervals
for the restart test.
@xylar xylar force-pushed the add-algorithm-for-global-ocean-cores-dt branch from 3626993 to fd68d99 Compare May 14, 2023 04:12
@xylar
Copy link
Collaborator Author

xylar commented May 14, 2023

Retested on Chrysalis after merging #630 and rebasing. I'm seeing non-BFB results for the cosine bell on Chrysalis in addition to the 5 tests mentioned above. Differences are only for the QU60 test and are at roundoff.

@xylar xylar merged commit d989d68 into MPAS-Dev:main May 14, 2023
@xylar xylar deleted the add-algorithm-for-global-ocean-cores-dt branch May 14, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant