-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get global ocean resources and time steps based on mesh size #631
Get global ocean resources and time steps based on mesh size #631
Conversation
I'm still seeing hanging in my tests of this branch, similar to #629. In this case, it's for |
ce6e5d8
to
4344de0
Compare
TestingI ran the All other tests are passing. |
d07ced3
to
3bbfd93
Compare
211b093
to
3626993
Compare
This is used to compute the number of MPI tasks based on the number of grid cells
We want to get the core count from either the estimated or exact core count and the time step from the minimum resolution.
This is because it may not work with the prescribed time intervals for the restart test.
3626993
to
fd68d99
Compare
Retested on Chrysalis after merging #630 and rebasing. I'm seeing non-BFB results for the cosine bell on Chrysalis in addition to the 5 tests mentioned above. Differences are only for the QU60 test and are at roundoff. |
This merge switches many global ocean steps to getting the core count from either an estimate or exact number of cells in the mesh. Similarly, it switches to computing the time steps (both barotropic and baroclinic) from the minimum resolution of the mesh.
This work paves the way for generalized QU and icosahedral global ocean meshes.
Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
in this PR) any testing that was used to verify the changes