Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nEdges float --> int in graph files #674

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Aug 18, 2023

Before this fix, we were seeing culled_graph.info files like:

7435 21369.0
8 3 2
1 7 9 8
...

The number of edges was being converted to a float because of a non-integer division by 2.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added bug Something isn't working framework labels Aug 18, 2023
@xylar xylar requested a review from gcapodag August 18, 2023 06:53
@xylar xylar self-assigned this Aug 18, 2023
@xylar
Copy link
Collaborator Author

xylar commented Aug 18, 2023

Testing

I ran the QUwISC240 mesh test case after cherry-picking these 2 commits onto #668. I now see:

7435 21369
8 3 2
1 7 9 8
8 10 4 1
...

as expected.

@xylar xylar removed the request for review from gcapodag August 18, 2023 07:42
@xylar xylar merged commit 3d33680 into MPAS-Dev:main Aug 18, 2023
@xylar xylar deleted the fix-graph-file-float-nedges branch August 18, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant