Perform flood fills on the land-ice mask #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another flood fill also makes sure the mask is contiguous (no small, isolated pockets of land ice).
xylar
force-pushed
the
flood-fill-land-ice-mask
branch
from
87beffb to
707dc28
Compare
A function previously from the Compass cull module now needs to come from MPAS-Tools and the syntax needs to change accordingly.
xylar
force-pushed
the
flood-fill-land-ice-mask
branch
from
707dc28 to
eb5895c
Compare
TestingI uses this branch on IcoswISC240, IcoswISC30 and RRSwISC6to18 meshes. In all cases, "islands" of isolated land-ice were removed from |
|
I also ran the |
This was referenced Mar 28, 2024
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 13, 2024
Add new RRSwISC6to18E3r5 ocean and sea-ice mesh Long name: RRSwISC6to18L80E3SMv3r5 This RRS (Rossby-radius scaled) mesh has: * 6 km resolution near the poles * 18 km resolution at the equator This is a proposed E3SM v3 (E3) high resolution (near-eddy-resolving) mesh. This is revision 5 (r5) of the mesh, which includes a flood fill of the land-ice mask to ensure correct connectivity (MPAS-Dev/compass#800). The minimum water-column thickness has been set to 20 m. [BFB] for all currently tested configurations
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 14, 2024
Add new RRSwISC6to18E3r5 ocean and sea-ice mesh Long name: RRSwISC6to18L80E3SMv3r5 This RRS (Rossby-radius scaled) mesh has: * 6 km resolution near the poles * 18 km resolution at the equator This is a proposed E3SM v3 (E3) high resolution (near-eddy-resolving) mesh. This is revision 5 (r5) of the mesh, which includes a flood fill of the land-ice mask to ensure correct connectivity (MPAS-Dev/compass#800). The minimum water-column thickness has been set to 20 m. [BFB] for all currently tested configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge makes sure the land-ice mask does not have holes (by flood filling an "ocean" mask that is the inverse of the land-ice mask) and then ensures that all land-ice cells are connected to each other (by flood filling the land-ice mask from the south pole).
Checklist
Testingin this PR) any testing that was used to verify the changes