Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to compass 1.4.0-alpha.4, numpy >=2.0, mpas_tools 0.34.1, matplotlib >=3.9.0 #838

Merged
merged 9 commits into from
Jul 4, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 3, 2024

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added ocean land ice dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Jul 3, 2024
@xylar xylar self-assigned this Jul 3, 2024
@xylar xylar requested review from trhille and sbrus89 July 3, 2024 18:12
@xylar xylar marked this pull request as draft July 3, 2024 18:31
@xylar
Copy link
Collaborator Author

xylar commented Jul 3, 2024

Testing

I successfully ran the pr and full_integration suites on Chrysalis (the former with Intel, the latter with Gnu). I needed the fix from MPAS-Dev/MPAS-Tools#574 so I will need to make a new MPAS-Tools release (0.34.1) with that fix.

@xylar xylar marked this pull request as ready for review July 3, 2024 20:01
@xylar
Copy link
Collaborator Author

xylar commented Jul 3, 2024

@trhille and @sbrus89, I'm pinging you both for a quick review by inspection because I had to do some linting of code that I think you both might be the original authors of. Could you take a quick look and make sure I didn't break anything that you can see just by visual inspection? Feel free to run some tests if you like. Make sure to --recreate the compass environment you use because of the new package constraints here.

@xylar xylar changed the title Update to numpy >=2.0, mpas_tools 0.34.1, matplotlib >=3.9.0 Update to compass 1.4.0-alpha.4, numpy >=2.0, mpas_tools 0.34.1, matplotlib >=3.9.0 Jul 3, 2024
Copy link
Collaborator

@trhille trhille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar, I'm approving by inspection of the landice tests. The changes there all look correct and innocuous, but I haven't tested. (By the way, @matthewhoffman was actually the one who wrote each of these landice cases.)

@xylar
Copy link
Collaborator Author

xylar commented Jul 4, 2024

By the way, @matthewhoffman was actually the one who wrote each of these landice cases.

Ah, good to know. GitHub recommended you as a reviewer so I just assumed you must be the author but that makes sense.

@matthewhoffman, feel free to have a look but I think @trhille took care of it.

@xylar
Copy link
Collaborator Author

xylar commented Jul 4, 2024

@sbrus89, I'm going to hope for the best and merge this. Without these changes, newly generated conda environments are broken.

I'm happy to help fix any problems that emerge with the tides test cases later on.

@xylar xylar removed the request for review from sbrus89 July 4, 2024 07:21
@xylar xylar merged commit d75450b into MPAS-Dev:main Jul 4, 2024
4 checks passed
@xylar xylar deleted the update-to-numpy-2.0 branch July 4, 2024 07:21
@matthewhoffman
Copy link
Member

Looks good to me. Thanks, Xylar and Trevor for taking care of it.

@xylar xylar mentioned this pull request Jul 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script land ice ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants