-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to compass 1.4.0-alpha.4, numpy >=2.0, mpas_tools 0.34.1, matplotlib >=3.9.0 #838
Conversation
The latest `master` includes a bug fix needed for numpy 2.0 support.
TestingI successfully ran the |
@trhille and @sbrus89, I'm pinging you both for a quick review by inspection because I had to do some linting of code that I think you both might be the original authors of. Could you take a quick look and make sure I didn't break anything that you can see just by visual inspection? Feel free to run some tests if you like. Make sure to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar, I'm approving by inspection of the landice tests. The changes there all look correct and innocuous, but I haven't tested. (By the way, @matthewhoffman was actually the one who wrote each of these landice cases.)
Ah, good to know. GitHub recommended you as a reviewer so I just assumed you must be the author but that makes sense. @matthewhoffman, feel free to have a look but I think @trhille took care of it. |
@sbrus89, I'm going to hope for the best and merge this. Without these changes, newly generated conda environments are broken. I'm happy to help fix any problems that emerge with the |
Looks good to me. Thanks, Xylar and Trevor for taking care of it. |
Checklist
Testing
in this PR) any testing that was used to verify the changes