Add QGreenland monthly median sea ice extent shape files

[alexolinhager]

Adds the monthly median sea ice extent (1981–2010) shape files from the QGreenland dataset. The original line segments delineating sea ice extent have been manually connected to create one coherent shape file.

[cbegeman]

@alexolinhager Can you provide any other information in the docs that would help users track down the source of this dataset? Maybe a permanent identifier if that exists?

[xylar]

It seems like the name got changed to December but the directory is still April. That shouldn't be possible if you do gf.split(fc) to split out the features into the directories in geometric_data. But I think April is probably correct and the change to December was a mistake?

[alexolinhager]

Thanks @xylar. That was just a typo copied from another file, I just pushed a fix for it

[alexolinhager]

@alexolinhager Can you provide any other information in the docs that would help users track down the source of this dataset? Maybe a permanent identifier if that exists?

Good idea, I just added that to the metadata for each file

[matthewhoffman]

@alexolinhager Can you provide any other information in the docs that would help users track down the source of this dataset? Maybe a permanent identifier if that exists?

@alexolinhager , can you add the reference to the documentation as well?

[matthewhoffman]

@alexolinhager , when I add these regions to QGIS and project to a polar stereographic grid, I see seams at 180 degree longitude. I remember a discussion about this but I can't find it - is this expected?

[matthewhoffman]

@alexolinhager , thanks for putting this together. The PR looks good and I just have a few small stylistic requests, plus a question about a seam in the region when plotted as polar stereographic.

[matthewhoffman]

@xylar , is there a coding style guideline for this repo about correspondence between function/class names and file names?

[alexolinhager]

@alexolinhager , when I add these regions to QGIS and project to a polar stereographic grid, I see seams at 180 degree longitude. I remember a discussion about this but I can't find it - is this expected?

@matthewhoffman, Thanks for looking over these PRs. The seam is expected for these regions and comes from this script:

geometric_features/geometric_features/feature_collection.py

Line 319 in 93f71ba

def fix_antimeridian(self):

. Without it, geojson shape files crossing the 180 degree longitude or the poles become disjointed.

@xylar said they look as he would expect, although I think that conversation happened via Slack

[alexolinhager]

@alexolinhager Can you provide any other information in the docs that would help users track down the source of this dataset? Maybe a permanent identifier if that exists?

@alexolinhager , can you add the reference to the documentation as well?

No problem, I made this change

[xylar]

@alexolinhager, there are some conflicts here. I can fix them but the cleanest would be if you're okay with rebasing onto main and fixing them that way.

[alexolinhager]

@alexolinhager, there are some conflicts here. I can fix them but the cleanest would be if you're okay with rebasing onto main and fixing them that way.

No problem, I'll work on that now

[alexolinhager]

@Xyler, I rebased the branch and pushed a couple other minor tweaks in accordance with Matt's review. Should be ready to merge now

[matthewhoffman]

@alexolinhager , thanks for the additional changes. Looks good to me.

[xylar]

Looks good to me.

[xylar]

@cbegeman, do you have time to approve or request further changes?

[cbegeman]

@alexolinhager All of my suggestions were addressed. Thanks for your hard work on this!