Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 lint in geometric_features #223

Merged
merged 6 commits into from
Dec 21, 2024
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 21, 2024

This merge addresses all the lint identified by flake8 within the geometric_features package. Notably, it doesn't address the feature_creation_scripts directory, which is there for provenance and we don't necessarily try to keep it clean or up-to-date.

@xylar xylar added the clean up label Dec 21, 2024
@xylar xylar self-assigned this Dec 21, 2024
@xylar
Copy link
Collaborator Author

xylar commented Dec 21, 2024

@altheaden, it seems like flake8 and maybe the other pre-commit features are running on all files in CI and not just the modified files. Can you figure out how to change that? Feel free to push changes here.

@xylar
Copy link
Collaborator Author

xylar commented Dec 21, 2024

@altheaden, as I just slacked you, I got it.

@xylar xylar merged commit 383777e into MPAS-Dev:main Dec 21, 2024
6 checks passed
@xylar xylar deleted the fix-flake8 branch December 22, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant