Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add files from m63203. HEIF region items. Canon #108

Closed
wants to merge 5 commits into from

Conversation

podborski
Copy link
Member

Note that the contribution m63203 has more dumps that can be used to finalize this PR.

@podborski podborski added the conformance-file This initiates file feature extraction on PRs label Oct 19, 2023
@cconcolato
Copy link
Contributor

Reviewers needed.

@fmaze
Copy link

fmaze commented Jan 24, 2024

From discussion in GitHub#82 it would appear that at least the region-polygon.heic example is currently invalid.

The region-polygon.heic example has Item 2 -[cdsc]-> Item 100, and Item 100 -[cdsc]-> Item 1 where Item 1 and 2 are 'hvc1' and Item 100 is 'rgan'.

But, we should rather have Item 100 -[eroi]-> Item 2, and Item 100 -[cdsc]-> Item 1.

In 23008-12 2nd ed. clause 6.10.3, (and future update in latest draft of 23008-12 2nd ed. FDAM1 clause 11.3.1), it is stated that region item rgan is associated with:

  • "metadata items, using an item reference of type 'cdsc' from the metadata item to the region item"
  • "image items (...), using an item reference of type 'eroi' from the region item to the image item (...)"

@bradh
Copy link
Contributor

bradh commented Jan 24, 2024

There are definitely more examples in this PR where there is an [image] -[cdsc]-> [rgan item] reference. For example, the region-rectangle.heic appears the same.

podborski added a commit that referenced this pull request May 10, 2024
Since this PR re-submits the files we can close #108
@podborski
Copy link
Member Author

This PR is replaced with #137

@podborski podborski closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance-file This initiates file feature extraction on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants