Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target calculation corrupted when index column is present #18

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

thorstenwagner
Copy link
Collaborator

The fixes the problem by using only numeric title columns for target estimation

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0aeb42d) 34.70% compared to head (701e895) 34.38%.

Files Patch % Lines
src/napari_tomotwin/make_targets.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   34.70%   34.38%   -0.32%     
==========================================
  Files           5        5              
  Lines         219      221       +2     
==========================================
  Hits           76       76              
- Misses        143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorstenwagner thorstenwagner merged commit ea501de into main Nov 29, 2023
2 of 4 checks passed
@thorstenwagner thorstenwagner deleted the fix-indexing-bug branch January 24, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant