mrconvert: Update dw_scheme on -bvalue_scaling #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows from #2015. If the -bvalue_scaling command-line option is used, always update the diffusion gradient table based on internal calculations, regardless of whether or not scaling was performed or not or whether it was necessary or not.
jdtournier
approved these changes
Jun 30, 2020
Member
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
Happy enough with this, though I must admit I'm not convinced I understand the need for it. But it's harmless enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows from #2015.
If the user has gone to the extent of manually using the
mrconvert -bvalue_scalingoption, regardless of the value specified, I think the full-precision contents ofdw_schemeshould be written to the output image header, regardless of any other contextual information.Actual effect will be very minimal; really the only change will be if
-bvalue_scalingis used but the gradient vectors are already almost of unit norm. Only came across this while hunting for numerical differences between software versions.