Skip to content

Conversation

@jdtournier
Copy link
Member

Minor issue reported by @dchristiaens , but fixes a problem left over from #1586. This only influences the progressbar updates when redirected away from the terminal.

Example for a simple mrconvert DICOM to nii conversion:

mrconvert 3dfl/ anat.nii 2> log.txt

Content of log.txt using current master:

 done
============================================]
=====================]

Content of log.txt using this PR:

mrconvert: scanning DICOM folder "3dfl/"... done
mrconvert: reading DICOM series "fl3D_1x1x1_tra"... [==================================================]
mrconvert: copying from "XXXXXXXX...ri vol) [MR] fl3D_1x1x1_tra" to "anat.nii"... [==================================================]

@jdtournier jdtournier added the bug label May 22, 2020
@jdtournier jdtournier requested a review from a team May 22, 2020 16:11
@jdtournier jdtournier self-assigned this May 22, 2020
Copy link
Member

@dchristiaens dchristiaens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdtournier, this fixes the problem with the scripts I was running. I also tested on macOS and ZSH to be sure, all fine :)

@jdtournier jdtournier merged commit b0248c4 into master May 27, 2020
@jdtournier jdtournier deleted the fix_progressbar_under_redirection branch May 27, 2020 18:17
@jdtournier jdtournier added this to the MRtrix3 3.0.1 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants