dwifslpreproc: Don't discard modified dw_scheme #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to copying header properties from the original input DWI in order to preserve header key-values and appropriately concatenate "command_history", the contents of "dw_scheme" were being erroneously overwritten by the original gradient table of the input DWI. This fix ensures that the updated version generated during the script - whether including motion correction and/or explicit volume recombination - is propagated to the final output image.
Member
|
|
jdtournier
approved these changes
Jun 1, 2020
Member
Author
|
Only 4 hours per charge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on forum.
Bug is the consequence of #1389.
Unfortunately it seems nobody used explicit volume recombination on
devfor the last two years, I didn't spot the issue, and the script test suite has to calltesting_diff_headerwithout the-keyvalflag becauseeddyis stochastic...