dwifslpreproc: eddy error message #2073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where both cuda and openmp versions of eddy are available, the reason for the cuda version failing may be obscured because it is only the terminal output produced by the openmp version that is reported to the user. With this change, the messages produced by both cuda and openmp eddy commands will be concatenated into a new combined exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification resulting from my own needing to be able to catch eddy errors and modify parameters accordingly within an automated pipeline; but likely beneficial for users executing the script directly as well.
Basically, if the CUDA version of
eddyfails, the resulting error message gets essentially hidden, because the exception is caught, the OpenMP version is run, and the error message produced by that version may give no insight into why the CUDA version failed.With this change, if both the CUDA and OpenMP versions of
eddyfail, the resulting error messages are concatenated into a single exception. When that is raised, the user (/ wrapping script) is provided with the terminal outputs generated by both versions of the command, enabling proper diagnosis.