Skip to content

Conversation

@Lestropie
Copy link
Member

Request has been raised a couple of times, and may well prove useful locally for processing some historical data, so figured I'd just do it.

-topup_files option (and indeed if they specify -eddy_options " ... --topup= ...") allows the user to specify a location where topup has already been run, and dwifslpreproc will import the two necessary files, and otherwise proceed as normal as if topup had been run internally, e.g. performing an initial EPI distortion correction for the sake of producing a brain mask for eddy. The path specified by the user can be the topup output prefix, or one of the two files, and dwifslpreproc will find both files automatically.

Primarily to enable interfacing with Synb0-DISCO, as its principal output is the results of topup but its interface just about precludes its execution from within dwifslpreproc, so running that first and dwifslpreproc second makes more sense.

Also added some option groups to the dwifslpreproc help page while I was at it, since it's likely to continue getting more complex over time.

Closes #2144.

Allows for the prior execution of FSL topup, e.g. leveraging an external tool such as Synb0-DISCO, then having dwifslpreproc utilise those data internally.
When importing an existing topup output field spline coefficients image, perform a file copy rather than an mrconvert call, in order to preserve NIfTI intent codes required by applytopup.
@Lestropie Lestropie added this to the 3.1.0 updates milestone Aug 26, 2020
@Lestropie Lestropie requested a review from a team August 26, 2020 07:29
@Lestropie Lestropie self-assigned this Aug 26, 2020
Copy link
Member

@jdtournier jdtournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though I've not had a chance to test. I guess since this is going to dev, it'll get further testing before being released, so happy enough to merge. 👍

@Lestropie Lestropie merged commit b4a4cae into dev Sep 8, 2020
@Lestropie Lestropie deleted the dwifslpreproc_topup_files_option branch September 8, 2020 09:37
@Lestropie Lestropie linked an issue Sep 17, 2020 that may be closed by this pull request
Lestropie added a commit that referenced this pull request Jul 19, 2025
Errors in completion of Python CLI changes in #2678 to support addition of -topup_files option in #2150.
New tests ensure that set of intended possible user-specified paths are supported.
Lestropie added a commit that referenced this pull request Jul 19, 2025
Errors in completion of Python CLI changes in #2678 to support addition of -topup_files option in #2150.
New tests ensure that set of intended possible user-specified paths are supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH dwifslpreproc: Manually provide topup estimated field

3 participants