for_each: Fix use of regex for entry exclusion #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of broad Except clause resulted in obscuring AttributeError when testing for regeex matches. This meant that input strings that should ideally have been omitted due to an exclusion regex would nevertheless be included in the process list.
jdtournier
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of broad Except clause resulted in obscuring
AttributeErrorwhen testing for regex matches. This meant that input strings that should ideally have been omitted due to an exclusion regex would nevertheless be included in the process list.Current
mastercode will generate a warning indicating that the exclude string did not match any input, even if when properly interpreted as a regex it should have. Test added here fails onmasterbut succeeds here. Also added some debug messages so that if the exclusion is not behaving as intended, it's possible to discriminate between a regex failing to compile vs. compiling but nevertheless not matching.