Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in MRtrix3/containers#14.
Plan is to have the primary container building recipes inside the main repository, and for the "
containers" repository to only be responsible for building the minified dependencies.In order for the recipe file contained within any particular tagged version of MRtrix3 to be guaranteed to clone that very same version of MRtrix3 during the build process, the recipe files must be manually updated to reflect the upcoming tag name, similarly to the gymnastics already done with
core/version.h. The Wiki instructions have already been updated accordingly.I have moved some of the contents of
README.mdfrom thecontainersrepo into a new page in the online documentation page.Reflecting on the contents of
README.mdin this repository, there's quite a lot of stripped-down instructions for compilation from source. Not only is it less comprehensive that the online documentation for building from source, but we expect over time that less people will be building from source. It might be worth contemplating removing these instructions altogether and instead relying on selection of which hyperlink to follow based on the desired installation route.It would be preferable to add instructions for running
mrviewvia containers on OSX and Windows prior to merge.This is currently targeted for
master. I don't think there should actually be any problem with either merging this tomasterprior to tagging, or with bundling it up with whatever hotfixes go into the next macro release, though I don't actually recall the result of discussion on the latter. Documentation may not cover all bases if it's included in a macro release, but that can nevertheless be revised onmasterif necessary. Note that dwi2mask overhaul (replacement PR) #2197 will necessitate the construction of new container dependency downloads, but that targets3.1.0, so can be addressed on a separate branch on theMRtrix3/containersrepo.This PR does not yet address the prospect of automatic building of containers. Given the relative occurrence of updates, such automation is not necessarily a prerequisite for this PR.