Skip to content

Conversation

@Lestropie
Copy link
Member

As per comment in #2356.

The theory here is that:

  • If someone checks out the code in 3.0.3, and then builds a container using one of the recipe files, during the building of that container it should download and compile the MRtrix3 code specifically at tag 3.0.3, regardless of how master may have changed after that point;

  • If someone checks out the code in master, and then builds a container using one of the recipe files, during the building of that container it should download and compile whatever the MRtrix3 master branch is pointing to at that point in time, regardless of what tags may or may not have been added.
    (Better would be if, during container build, it would check out the MRtrix3 code at the commit hash corresponding to the code version of the recipe that is dictating the build process; but I have not yet thought about how such could be achieved).

@Lestropie Lestropie requested a review from a team July 19, 2021 10:38
@Lestropie Lestropie self-assigned this Jul 19, 2021
@jdtournier jdtournier merged commit 4824f0e into master Jul 19, 2021
@jdtournier jdtournier deleted the revert_recipes_to_master branch July 19, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants