Update copyright and docs #2425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems changes in ArgParse are causing issues in our automatic docs generation on the Python side. It looks like the name for the default option group has changed from 'optional arguments' to 'options', so we now need to check against both to ensure consistent output.
bjeurissen
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required update to copyright and corresponding docs to enable tests to pass.
Note this also includes a change in 8d0670a to handle upstream changes in ArgParse, whereby the name for the default option group has now been changed from 'optional arguments' to the (arguably more sensible) 'options'. Means we now need to check against both possible names in the help page generation code.