configure: ignore CFLAGS & LDFLAGS from qmake #2445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LTO options introduced with Qt 5.15 cause non-trivial conflicts with clang++. Furthermore, the flags added by Qt typically don't add much over what we normally use.
Member
Author
|
Just to clarify: this will only affect the compiler and linker flags used while compiling Qt / GUI apps. No impact on command-line only apps. I'll check this on Windows 10 as well, that's the OS most likely to break with these changes. |
Member
|
works with: |
Member
Author
|
Works fine on Windows 10 under MSYS2 as well. I think it's safe to merge. Can I get a review please...? 😁 |
maxpietsch
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LTO options introduced with Qt 5.15 cause non-trivial conflicts with clang++ (at least it does on Arch Linux). I expect this will start to become problematic for other users soon.
Looking at the flags added by Qt, it looks like they don't add much over what we normally use. It's probably just as easy to ignore the additional flags that
qmakesuggest (CFLAGS&LDFLAGS), and stick to grabbing only the main ones (DEFINES,INCPATH&LIBS).Works fine on Linux, will need checking on other OS's.