-
Notifications
You must be signed in to change notification settings - Fork 191
Dicom fix missing import siemens enhanced #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OK, I added a couple more fixes while I was at it. I had issues with the Siemens synthetic DW (TRACEW) images - they all came out as one big 3D stack rather than the expected 4D multiple volumes (one per synthetic b-value). We also had trouble converting the colFA (RGB) images correctly. Everything now checks out with these last two commits. All testing checks out now, including all datasets provided recently from various sources (thanks @bjeurissen & @neurolabusc). I did have to update some of the validation data since the updates on this branch extract more information from the DICOM headers than previously, but that's expected, and I verified that all the changes make sense. The full output of that last round of testing is shown below for reference: |
The multiband acceleration factor is to my knowledge not actually encoded directly anywhere, and is instead calculated based on the slice timings. While technically the slice encoding axis could be encoded (for 2D sequences) regardless of knowledge of slice timings, just not knowing the sign of traversal means that you probably wouldn't want to set |
Based on test data provided by @bjeurissen where some attributes were missing , namely
SliceTiming,EchoTime,MultibandAccelerationFactor&SliceEncodingDirection. For some reason, fixing the slice timing import also fixed the MB factor and slice direction imports (presumably because these are only carried over if the slice timings are known).The
EchoTimecan be imported correctly if we accept theEffectiveEchoTimeas equivalent. Not sure whether that will cause problems down the track, but it probably feels safe enough for now...?