Python: don't cleanup on SIGINT if -nocleanup option has been provided #2484
Conversation
Lestropie
left a comment
Lestropie
left a comment
There was a problem hiding this comment.
Yep, keep encountering this myself but never got around to fixing it.
Outstanding question however is whether the terminal message should be exactly the same (ie. report receipt of signal), or whether text reporting the retainment of the scratch directory and its location (which gets printed upon failure / completion if -nocleanup is specified) should be recapitulated here.
Lestropie
left a comment
Lestropie
left a comment
There was a problem hiding this comment.
This should now do as initially desired but also print the location of the scratch directory if the handler is invoked but -nocleanup` was specified.
|
Does anybody else want to review this given I changed all of the code? |
I would, but GitHub won't let me as I'm the originator for this pull request... But I have looked at the code, and I approve! |
When debugging long-running scripts (such as
dwifslpreproc), it's sometimes useful to interrupt the process when it's already moved on from the problematic stage, but hitting Ctrl-C currently deletes the temporary folder even if the process was invoked with-nocleanup, which IMO is unexpected. This seems to fix it.