matlab: Fix erroneous reference to non-existent "tracks" identifier #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaEyoung
changed the title
Member
|
Has anyone had a chance to double-check this now works...? Seems legit to me, but then I reviewed the commit that introduced the bug in the first place, so maybe it would be best for someone else to review... |
Lestropie
approved these changes
Nov 14, 2022
Member
Lestropie
left a comment
Lestropie
left a comment
There was a problem hiding this comment.
Absolving @jdtournier of review responsibility.
Certainly looks like it should resolve #2521, and hard to see it introducing any new problem, so I'm happy for it to go to master and see if any other issue is subsequently reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error introduced by overzealous copypasting in #2455, pointed out in #2521.
While I was there, also replaced other references to the "tracks" variable in the function description and error messages (hope that's appropriate?)