Skip to content

Conversation

@Lestropie
Copy link
Member

Command-line option non-functional due to an error in prior modification of the option name in #1932.

Fully expect that nobody other than myself has ever attempted to use this option. It's primarily to facilitate a more advanced fixel segmentation that I've never had the opportunity to finish off. So most likely hasn't detrimentally impacted any users. Indeed if anyone had used it, I would hope that they would have discovered that there were no differences in FOD segmentation between inclusion and omission of the option.

Mismatch between option string as loaded in usage() and the get_options() call results in user-specified option being ignored.
Error introduced in b435e58 as part of #1932.
@Lestropie Lestropie added the bug label May 21, 2023
@Lestropie Lestropie requested a review from a team May 21, 2023 08:37
@Lestropie Lestropie self-assigned this May 21, 2023
@bjeurissen bjeurissen added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 8b2f58f May 15, 2024
@bjeurissen bjeurissen deleted the fod2fixel_merge_option branch May 15, 2024 09:31
@Lestropie Lestropie mentioned this pull request Jan 14, 2025
31 tasks
Lestropie added a commit that referenced this pull request Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061.
- #2693 (completely omitted)
- #3005 (partial propagation / independent address of some common issues on both branches)
- #3001 (completely omitted)
- #2908 (completely omitted)
- #2955 (completely omitted)
- #2600 (completely omitted)
- #2962 (completely omitted)
- #2935 (completely omitted)
- #2923 (completely omitted)
- #2910 (completely omitted)
- #2638 (completely omitted)
- #2698 (completely omitted)
- #2721 (completely omitted)
- #2794 (completely omitted)
- #2768 (completely omitted; required modification to conform to other dev changes)
- #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Lestropie added a commit that referenced this pull request Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061.
- #2693 (completely omitted)
- #3005 (partial propagation / independent address of some common issues on both branches)
- #3001 (completely omitted)
- #2908 (completely omitted)
- #2955 (completely omitted)
- #2600 (completely omitted)
- #2962 (completely omitted)
- #2935 (completely omitted)
- #2923 (completely omitted)
- #2910 (completely omitted)
- #2638 (completely omitted)
- #2698 (completely omitted)
- #2721 (completely omitted)
- #2794 (completely omitted)
- #2768 (completely omitted; required modification to conform to other dev changes)
- #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
@Lestropie Lestropie restored the fod2fixel_merge_option branch August 26, 2025 08:11
@Lestropie Lestropie deleted the fod2fixel_merge_option branch August 27, 2025 00:21
@Lestropie Lestropie mentioned this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants