-
Notifications
You must be signed in to change notification settings - Fork 191
Concatenate nested namespaces for C++17 #2641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @daljit46! I have a feeling this may best be done under the authorship of @MRtrixBot though... What do you reckon, @Lestropie? |
|
|
For the formatting, I think it might be a good idea to not format the code when merging this change. Formatting will lead to merge conflicts (since we are planning to merge other branches like #2620). Instead, we could merge a branch with changes to namespaces only and only subsequently merge one that contains the necessary formatting changes. More generally, I would be in favour of a standard formatting convention that uses clang-format. It would provide consistency and a clear constraint on how developers are ought to format their code (with no room for arguments on style). I see very little benefit in giving the developers the possibility to introduce all kind of different formatting conventions and it's not pretty to see commits changing the formatting of unrelated code (especially when a pull request is the work of multiple contributors). |
4a1c5ce to
64e906b
Compare
75ba90e to
94cefcf
Compare
|
This seems ready to be merged now that we have implemented automatic formatting rules via #2652. |
12cb5bc to
df87d3c
Compare
|
@Lestropie actually it probably make sense to wait for #2818 to be merged before. |
df87d3c to
10f3e20
Compare
This concatenates nested namespaces which is a features that has been introduced in C++17. It partially addresses #2585.
The changes were made with the help of Bear and clang-tidy. I haven't bothered with formatting yet, but we may want to automate this too using something like clang-format.