dwifslpreproc: Fix for PE direction, but not readout time, in header #2722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the phase encoding information present in the header is only the phase encoding direction, but not readout time is present, then the constructed phase encoding matrix will possess only three columns, not four. If this happens, but an attempt is then made to cross-reference the readout time in the phase encoding table generated from header content against what the user has specified at the command-line, then an unhandled exception will occur. This change prevents specifically the comparison of readout times from being made if no such information is present. Replacement for erroneous commit faf0788. Also includes additional test that results in an unhandled exception on 3.0.4 but executes successfully with this change.
Lestropie
force-pushed
the
dwifslpreproc_no_readouttime_in_header
branch
from
faf0788 to
3732dbc
Compare
Member
Author
|
Fixed & added test as proof. Seeking approval review. |
daljit46
approved these changes
Feb 5, 2025
Lestropie
added a commit
that referenced
this pull request
Aug 11, 2025
Because the section of code responsible for running FSL applytopupup now makes use of a temporary NIfTI image, diffusion and phase encoding data are absent. This resulted in failure of the subsequent dwi2mask call. Here the diffusion gradient table and other header key-value metadata are explicitly tracked for each individual volume group defined by phase encoding, so that they can be later suitably combined during image concatenation. Additionally fixes typo in dwifslpreproc test added in #2722.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error encountered by user attempting to process their own data during workshop.
Description in faf0788.