-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DWI metadata fixes for master #3011
Open
Lestropie
wants to merge
10
commits into
master
Choose a base branch
from
dwi_metadata_master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ca55d14 - Browse repository at this point
Copy the full SHA ca55d14View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a5a76ad - Browse repository at this point
Copy the full SHA a5a76adView commit details
Commits on Sep 19, 2024
-
This commit is a manual replication of the contents of #2917, but targeting 3.0.x.
Configuration menu - View commit details
-
Copy full SHA for 339ea0c - Browse repository at this point
Copy the full SHA 339ea0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dfb6ec - Browse repository at this point
Copy the full SHA 7dfb6ecView commit details -
JSON import: Preserve precision of numerical types
Do not convert contents of text JSON file to integers / floats then convert back to strings for storage in a KeyValues instance; instead just use the string representation. This fixes an issue whereby if a JSON is generated from an image, but that image also retains the same metadata fields in its own header, and then the JSON contents are re-imported, the two values for floating-point metadata elements could differ due to floating-point imprecision, and this would lead to the field being reset to the value "variable".
Configuration menu - View commit details
-
Copy full SHA for b160d21 - Browse repository at this point
Copy the full SHA b160d21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01a09b8 - Browse repository at this point
Copy the full SHA 01a09b8View commit details
Commits on Sep 22, 2024
-
In order for a bvecs file to be properly read in, the information about how the image was transformed upon image load needs to be available. However if an attempt is made to perform such a read based on a Header that it has itself been constructed from an arbitrary ImageType, this information is lost. Therefore, reading from a bvecs file needs to be done using the Header class in which the corresponding NIfTI was originally opened. In the process, some functionalities of the tracking of that transformation on image load have been made more explicit. Also fixes some syntax errors relating to the manual back-porting of #2917 in #3011.
Configuration menu - View commit details
-
Copy full SHA for 2be257c - Browse repository at this point
Copy the full SHA 2be257cView commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1caea0 - Browse repository at this point
Copy the full SHA b1caea0View commit details
Commits on Nov 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 79c4ba4 - Browse repository at this point
Copy the full SHA 79c4ba4View commit details -
Handle inconsistent phase encoding on non-volume concatenation
Concatenation of images along an axis other than 3, where phase encoding information differed, results in "PhaseEncodingDirection": "variable". Previously this was dissapearing silently; but with #3011, this instead threw an unhandled Exception.
Configuration menu - View commit details
-
Copy full SHA for fc0e8f1 - Browse repository at this point
Copy the full SHA fc0e8f1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.