Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWI metadata fixes for master #3011

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

DWI metadata fixes for master #3011

wants to merge 10 commits into from

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    ca55d14 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    a5a76ad View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. DWI metadata fixes

    This commit is a manual replication of the contents of #2917, but targeting 3.0.x.
    Lestropie committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    339ea0c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7dfb6ec View commit details
    Browse the repository at this point in the history
  3. JSON import: Preserve precision of numerical types

    Do not convert contents of text JSON file to integers / floats then convert back to strings for storage in a KeyValues instance; instead just use the string representation. This fixes an issue whereby if a JSON is generated from an image, but that image also retains the same metadata fields in its own header, and then the JSON contents are re-imported, the two values for floating-point metadata elements could differ due to floating-point imprecision, and this would lead to the field being reset to the value "variable".
    Lestropie committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b160d21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01a09b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Fixes to bvecs import

    In order for a bvecs file to be properly read in, the information about how the image was transformed upon image load needs to be available. However if an attempt is made to perform such a read based on a Header that it has itself been constructed from an arbitrary ImageType, this information is lost. Therefore, reading from a bvecs file needs to be done using the Header class in which the corresponding NIfTI was originally opened.
    In the process, some functionalities of the tracking of that transformation on image load have been made more explicit.
    Also fixes some syntax errors relating to the manual back-porting of #2917 in #3011.
    Lestropie committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    2be257c View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    b1caea0 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Configuration menu
    Copy the full SHA
    79c4ba4 View commit details
    Browse the repository at this point in the history
  2. Handle inconsistent phase encoding on non-volume concatenation

    Concatenation of images along an axis other than 3, where phase encoding information differed, results in "PhaseEncodingDirection": "variable". Previously this was dissapearing silently; but with #3011, this instead threw an unhandled Exception.
    Lestropie committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    fc0e8f1 View commit details
    Browse the repository at this point in the history