Suppress erroneous warning RE merging of gradient table #3106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erroneous warning issued in circumstance where DWIs are being concatenated along the volume axis and have different phase encoding tables.
Following #3027 in version 3.0.5, commands could produce an erroneous warning whenever concatenating images along the volume axis where those images contained diffusion gradient tables that did not match. Where concatenation occurrs along the volume axis, the gradient table itself gets concatenated rows. This was operating correctly, but underlying function Header::merge_keyval() was issuing erroneous earnings regarding an inability to merge the gradient tables directly prior to the concatenation operation taking place. This could occur if using the multi-file numbered image capability acorss volumes, or if concatenating across image series that contain different gradient tables.
Member
Author
|
Just to aid in review: Code on this PR: |
jdtournier
approved these changes
Jun 24, 2025
Member
jdtournier
left a comment
jdtournier
left a comment
There was a problem hiding this comment.
Took me a while, but it all makes sense, happy to merge.
Lestropie
pushed a commit
that referenced
this pull request
Aug 26, 2025
Suppress erroneous warning RE merging of gradient table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially thought that this was a minor annoyance that only affected specific data, but turns out to have been more widespread. See description in 568b28e.
3.0.5fails the second of the three new tests. Problem introduced in #3027, so 3.0.4 unaffected.Even if concatenating two 4D series along the volume axis, where the two gradient tables should be stacked atop one another,
mrcatproduces a warning about an inability to merge gradient tables. The appropriately concatenated gradient table would still be present in the output image, it would just be an erroneous warning at the terminal.Involves an addition of test data (in retrospect wasn't strictly necessary, but might be of use elsewhere); so
masterbranch on test_data repo should be forwarded upon PR merge.