Update configure script for Xcode26 compatibility #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt5 links to both OpenGL and AGL for OpenGL apps, but AGL is no longer included in MacOS Tahoe/Xcode26 (https://bugreports.qt.io/browse/QTBUG-137687). This will cause our configure script to fail on latest macOS. This issue will not be addressed in future Qt5 versions (only in Qt6), but we can work around it by explicitly linking only to OpenGL.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the configure script to ensure compatibility with Xcode 26 on macOS Tahoe by explicitly setting the OpenGL framework linking configuration for Qt5 applications.
- Adds explicit OpenGL framework linking configuration for macOS builds
- Works around Qt5's default behavior of linking to both OpenGL and deprecated AGL frameworks
- Prevents configure script failures on latest macOS/Xcode versions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
Confirmed to work both pre-deprecation of AGL (macOS Sequoia) as post-deprecation of AGL (macOS Tahoe), so I think this change is solid. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt5 links to both OpenGL and AGL for OpenGL apps, but AGL is no longer included in MacOS Tahoe/Xcode26 (https://bugreports.qt.io/browse/QTBUG-137687). This will cause our configure script to fail on latest macOS. This issue will not be addressed in future Qt5 versions (only in Qt6), but we can work around it by explicitly linking only to OpenGL.