Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenFn to the project #103

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

taylordowns2000
Copy link

@taylordowns2000 taylordowns2000 commented Jan 11, 2024

Work in progress for discussion with team. (Will remove "draft" when ready.)

  1. Update project.yaml once new exporter/migrator is done on v1
  2. After compose, admin could run openfn deploy -c ./openfn/config.json and re-enter credentials?
  3. How to handle adaptor installation?
  4. How to handle saving projectState.json? (Do we want this saved to the repo also?)
  5. How to handle api keys?

@jnsereko
Copy link
Collaborator

jnsereko commented Jan 17, 2024

hey @taylordowns2000
Thank you for working on this

Could you be knowing why web is actually not connecting to the database?
I am getting (DBConnection.ConnectionError) connection not available and request was dropped from queue after 298

My env file is the same as https://github.com/OpenFn/Lightning/blob/main/.env.example

I also tried with a different pre-built image tag image: 'openfn/lightning:v2.0.0-rc3' and a different postgres (postgres:14-alpine) image but still i was not able to make the connection work

cc @michaelbontyes

@taylordowns2000
Copy link
Author

Hey @jnsereko , sorry but off the top of my head I don't. Are you running lightning locally outside of this docker compose file normally?

If not, I'd make sure:

  1. You're comfortable running lightning locally with elixir and postgres. (Maybe skip this step if you haven't run Elixir apps before and don't plan on doing any local development.)
  2. You're comfortable running it with the compose file mentioned here: https://openfn.github.io/Lightning/readme.html#run-via-docker
  3. Then circle back and take a peek at the integration with this existing docker-compose setup.

And also feel free to close this PR if it's in the way as it isn't meant to work yet—at OpenFn we often use draft PRs as conversation starters. I don't expect the code here to run right now.

@jnsereko
Copy link
Collaborator

jnsereko commented Jan 17, 2024

Are you running lightning locally outside of this docker compose file normally?

Outside this docker compose file, ie running the main Lightning repo https://github.com/OpenFn/Lightning locally using docker, the web container actually makes the DB connection and it doesn't exit. However,http://localhost:4000 is actually not showing the expected pages.

I am troubleshooting to see if this is a problem with my docker compose or docker

@jnsereko
Copy link
Collaborator

AFAIK, using the Lightning repo, my local environment seams not to be the cause of localhost:4000 not showing the application basing on https://github.com/OpenFn/Lightning?tab=readme-ov-file#problems-with-docker. Also starting from scratch seam not to solve the issue

What i current wish to have is seeing the OpenFN Lightning application healthily running on localhost:4000 in this repo and i will try too tackle the synching of data later.

I don't expect the code here to run right now.

The changes you made in this repo's docker compose file look fine. Atleast the application should be showing up at localhost:4000.

Kindly let me know if you are locally not facing the database connection issue with this docker compose file in this repository

@jnsereko jnsereko changed the base branch from main to dev July 17, 2024 10:45
@jnsereko jnsereko changed the base branch from dev to main July 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants