Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate release pipeline and prevent GitHub artifact upload from zipping the artifact twice #1

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Separate release pipeline and prevent GitHub artifact upload from zipping the artifact twice #1

merged 1 commit into from
Apr 16, 2024

Conversation

jnsereko
Copy link
Collaborator

@jnsereko jnsereko commented Apr 16, 2024 •
edited
Loading

this ensures that

  • any change in distro directory will cause a new release of Mosul and Iraq since they are children-
  • any change in iraq directory will cause a new release of Mosul its a children
  • any change in Mosul directory will only cause a release Mosul
  • Artifact uploaded in with upload-artifact are zipped twice hence the installation script doesn't recursively unzip the file like the desktop unarchiver app would do. see upload-artifact double-zips a zip actions/upload-artifact#39

cc @michaelbontyes @pirupius

@jnsereko
Copy link
Collaborator Author

Merging expecting Iraq and Mosul artifacts to be released.
I can create a follow up PR in case of any concerns.

@jnsereko jnsereko merged commit 5a01e15 into MSF-OCG:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnsereko